Ensure unique tasks with the same description aren't diagnosed as duplicates #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic and
neonichu
as code owners
|
@swift-ci test |
cmcgee1024
approved these changes
May 30, 2025
There was a problem hiding this comment.
It probably won't matter in practice most of the time, but the variable-length hash components really should be framed (e.g. to ensure inputPaths=a, outputPaths=b,c,d is hashed differently than inputPaths=a,b outputPaths=c,d)
There was a problem hiding this comment.
good catch, fixed in the latest commit
jakepetroules
approved these changes
May 30, 2025
owenv
force-pushed
the
owenv/custom-task-dupes
branch
from
b7ea620 to
818b886
Compare
|
@swift-ci test |
cmcgee1024
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 4, 2025
This test case did not work until swiftlang/swift-build#541 was merged. Enable more plugin dependency testing. Allow more than one custom task per target in the PIF Builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate a signature of the CustomTask into the rule info alongside the description since custom tasks are arbitrarily flexible